Working site playground#3
Merged
Merged
Conversation
ryanrasti
added a commit
that referenced
this pull request
Apr 21, 2026
ryanrasti
added a commit
that referenced
this pull request
Jul 8, 2026
ColumnInfo is the contract between introspectors and generateTable, so it now speaks codegen's vocabulary — name / className / nullable / default / generated — instead of information_schema-ese (is_nullable: "YES", identity_generation, and the never-consulted is_generated). Each introspector translates its dialect-native facts at the boundary: PG maps identity + stored-generated columns; SQLite maps notnull + rowid-alias detection, no longer pretending rowid is IDENTITY "ALWAYS". Behavior change hiding in the cleanup: PG `GENERATED ALWAYS AS (...) STORED` columns previously emitted without `generated: true` because only identity_generation was consulted and is_generated was dead weight. The consolidated `generated` boolean covers both; locked by a new name_upper column in the postgres e2e snapshot. The sqlite/postgres e2e suites needed zero snapshot edits — the payoff of pinning tests to DDL-in/code-out rather than the intermediate shape this commit rewrites. Only generate.test.ts's fixture helper changed. FkInfo left as-is (already dialect-neutral). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.